[
https://issues.apache.org/jira/browse/GORA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295810#comment-15295810
]
ASF GitHub Bot commented on GORA-465:
-------------------------------------
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/67#discussion_r64160518
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -116,18 +114,8 @@ public void initialize(Class<K> keyClass, Class<T>
persistentClass,
mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY,
DEFAULT_MAPPING_FILE));
filterUtil = new HBaseFilterUtil<>(this.conf);
} catch (FileNotFoundException ex) {
- try {
- mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY,
DEPRECATED_MAPPING_FILE));
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename
the file to "
- + DEFAULT_MAPPING_FILE);
- } catch (FileNotFoundException ex1) {
- LOG.error(ex1.getMessage(), ex1);
- //throw (ex1); //throw the original exception
- } catch (Exception ex1) {
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename
the file to "
- + DEFAULT_MAPPING_FILE);
- throw new RuntimeException(ex1);
- }
+ LOG.error(DEFAULT_MAPPING_FILE + " is not found, please check the
file.");
--- End diff --
Can you please use the paramaterized slf4j logging notation here? e.g.
```
+ LOG.error("{} is not found, please check the file.",
DEFAULT_MAPPING_FILE);
```
> Remove @Deprecated logic for hbase-mapping.xml
> ----------------------------------------------
>
> Key: GORA-465
> URL: https://issues.apache.org/jira/browse/GORA-465
> Project: Apache Gora
> Issue Type: Test
> Components: gora-hbase
> Affects Versions: 0.6.1
> Reporter: Lewis John McGibbney
> Assignee: cihad güzel
> Priority: Trivial
> Fix For: 0.8
>
>
> We have some useless checking and log statements in HBaseStore which relate
> to a very old hbase-mapping.xml.
> These should just be removed.
> {code}
> @Deprecated
> private static final String DEPRECATED_MAPPING_FILE = "hbase-mapping.xml";
> ...
> try {
> mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY,
> DEPRECATED_MAPPING_FILE));
> LOG.warn("{} is deprecated, please rename the file to {}",
> DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
> } catch (FileNotFoundException ex1) {
> LOG.error(ex1.getMessage(), ex1);
> //throw (ex1); //throw the original exception
> } catch (Exception ex1) {
> LOG.warn("{} is deprecated, please rename the file to {}",
> DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
> throw new RuntimeException(ex1);
> }
> {code}
> etc
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
