[
https://issues.apache.org/jira/browse/GORA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873374#comment-15873374
]
ASF GitHub Bot commented on GORA-443:
-------------------------------------
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/95#discussion_r101905632
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableConnection.java
---
@@ -112,9 +112,9 @@ public void flushCommits() throws IOException {
for (ConcurrentLinkedQueue<Mutation> buffer : bPool) {
for (Mutation m: buffer) {
bufMutator.mutate(m);
+ bufMutator.flush();
}
}
- bufMutator.flush();
bufMutator.close();
--- End diff --
yeah I tried this as well, but this would mean that if we have millions of
operations buffered, we would flush each and every one of them one by one, but
even with this we couldn't get the tests to pass. IMO the bufMutator.flush()
should remain where it is, and we should find out why the mutations get applied
asynchronously when we call flush.
> Upgrade HBase to 1.2.3
> ----------------------
>
> Key: GORA-443
> URL: https://issues.apache.org/jira/browse/GORA-443
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-hbase
> Reporter: Ted Yu
> Assignee: Lewis John McGibbney
> Fix For: 0.7
>
>
> HBase 1.1.2 release is the current stable release.
> Gora should be built based on HBase 1.1.2
> Currently I got the following compilation error:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
> on project gora-hbase: Compilation failure
> [ERROR]
> /home/hbase/gora/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableConnection.java:[59,7]
> error: HBaseTableConnection is not abstract and does not override abstract
> method checkAndDelete(byte[],byte[],byte[],CompareOp,byte[],Delete) in Table
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
