Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/95#discussion_r101905632
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableConnection.java
---
@@ -112,9 +112,9 @@ public void flushCommits() throws IOException {
for (ConcurrentLinkedQueue<Mutation> buffer : bPool) {
for (Mutation m: buffer) {
bufMutator.mutate(m);
+ bufMutator.flush();
}
}
- bufMutator.flush();
bufMutator.close();
--- End diff --
yeah I tried this as well, but this would mean that if we have millions of
operations buffered, we would flush each and every one of them one by one, but
even with this we couldn't get the tests to pass. IMO the bufMutator.flush()
should remain where it is, and we should find out why the mutations get applied
asynchronously when we call flush.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
