[ 
https://issues.apache.org/jira/browse/GORA-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880233#comment-15880233
 ] 

ASF GitHub Bot commented on GORA-472:
-------------------------------------

Github user cloudysunny14 commented on the issue:

    https://github.com/apache/gora/pull/96
  
    I'm sorry for reopen this PR.
    
    I think that the cause of TestHBaseStore#testDeleteByQuery failure is the 
Delete#addColumn(byte[] family, byte[] qualifier) this delete the latest 
version of the specified column.
    
    Examples are as follows:
    
    * Delete#addColumn(byte[] family, byte[] qualifier)
    
    Put
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=4
    Put
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Put/vlen=35/seqid=6
    DELETE via Delete#addColumn (It does a get to find the latest versions 
timestamp and delete latest version of value)
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Delete/vlen=0/seqid=7
    GET
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=0
    
    
    * Delete#addColumns(byte[] family, byte[] qualifier)
    
    PUT
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571413/Put/vlen=35/seqid=4
    PUT
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571460/Put/vlen=35/seqid=6
    DELETE via Delete#addColumns (It deletes all versions of the specified 
column)
    
http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571506/DeleteColumn/vlen=0/seqid=7
    GET
    no result(puts are invisible)
    
    I thinks that the TestHBaseStore#testDeleteByQuery intends the latter.
    
    Please try TestHBaseStore after merge https://github.com/apache/gora/pull/95
    
    Kiyonari Harigae


> All gora-hbase tests to be comparative
> --------------------------------------
>
>                 Key: GORA-472
>                 URL: https://issues.apache.org/jira/browse/GORA-472
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase, testing
>            Reporter: Lewis John McGibbney
>             Fix For: 0.8
>
>
> I am starting to get a tad sad with seeing the following in sure fire reports
> {code}
> testDeleteByQueryFields(org.apache.gora.hbase.store.TestHBaseStore)  Time 
> elapsed: 13.287 sec  <<< FAILURE!
> java.lang.AssertionError
>       at org.junit.Assert.fail(Assert.java:92)
>       at org.junit.Assert.assertTrue(Assert.java:43)
>       at org.junit.Assert.assertTrue(Assert.java:54)
>       at 
> org.apache.gora.store.DataStoreTestUtil.assertWebPage(DataStoreTestUtil.java:740)
> {code}
> We need to start using the comparative aspect of the JUnit API, this enables 
> us to compare the results of what we got and what we expected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to