Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/103
Hi!
I don't find necessary to have tests on this issue. The reason is that the
issue is about a wrong placed logging -the need to move it out of the `for`-,
so I don't find anything to test and the fix looks perfect.
+1 to merge to master, since it solves
https://issues.apache.org/jira/browse/GORA-394 perfectly.
I suggest, as a later improvement in other issue, to discuss if it is
suitable to throw an exception after logging (fail fast when the configuration
is wrong) - and in this case a test will be needed, of couse :) -
@nishadi, thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
