[ 
https://issues.apache.org/jira/browse/GORA-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027887#comment-16027887
 ] 

ASF GitHub Bot commented on GORA-394:
-------------------------------------

Github user alfonsonishikawa commented on the issue:

    https://github.com/apache/gora/pull/103
  
    Commited, thank you very much, @nishadi .
    
    @madhawa-gunasekara : What was happening is that it was showing one message 
for each class not matching even when there were one class matching in all the 
classes list. The objective was to show only one message if neither of the 
classes matched. I commited at the same time as you commented :S Are you 
thinking about something I missed?


> Erroneous 'Error: KeyClass in gora-hbase-mapping is not the same as the one 
> in the databean.' log when reading HBase mapping
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-394
>                 URL: https://issues.apache.org/jira/browse/GORA-394
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase
>    Affects Versions: 0.4, 0.5
>            Reporter: Alfonso Nishikawa
>            Assignee: Nishadi Kirielle
>            Priority: Trivial
>              Labels: logging, mapping
>             Fix For: 0.8
>
>
> When reading the {{<class>}} mapping in gora-hbase in 
> [HBaseStore|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L756],
>  it keeps iterating all {{<class>}} tags until finds the one for the 
> datastore generic parameters (key and value matches).
> For that, [this {{else}} 
> block|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L790]
>  is erroneous because we expect the {{if}} to be true only once and false 
> serveral times, depending the number of entities defined in the mapping file.
> The error log "KeyClass in gora-hbase-mapping is not the same as the one in 
> the databean." must only be shown after finishing traversing all {{<class>}} 
> elements and finding no match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to