[ 
https://issues.apache.org/jira/browse/GORA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nishadi Kirielle updated GORA-512:
----------------------------------
    Description: 
In the current implementation, when reading the HBase mapping file, if the 
HBase mapping file does not have a matching key class and name to the data 
bean, it only logs that information.[1] It does not fail at the time of 
detecting it. It fails only at the time of building the mapper [2] when it 
detects the table name is null. It will be better if it can fail at the time of 
detecting that mapping file is missing the corresponding class. 

[1]. 
https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
[2]. 
https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815


  was:
In the current implementation, when reading the HBase mapping file, if the 
HBase mapping file does not have a matching key class and name to the data 
bean, it only logs that information.[1] It does not fails at the time of 
detecting it. It fails only at the time of building the mapper [2] when it 
detects the table name is null. 

[1]. 
https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
[2]. 
https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815



> Fail at the time of error logging if KeyClass in gora-hbase-mapping is not 
> the same as the one in the data bean
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-512
>                 URL: https://issues.apache.org/jira/browse/GORA-512
>             Project: Apache Gora
>          Issue Type: Improvement
>            Reporter: Nishadi Kirielle
>            Priority: Minor
>
> In the current implementation, when reading the HBase mapping file, if the 
> HBase mapping file does not have a matching key class and name to the data 
> bean, it only logs that information.[1] It does not fail at the time of 
> detecting it. It fails only at the time of building the mapper [2] when it 
> detects the table name is null. It will be better if it can fail at the time 
> of detecting that mapping file is missing the corresponding class. 
> [1]. 
> https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
> [2]. 
> https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to