[
https://issues.apache.org/jira/browse/GORA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039239#comment-16039239
]
Kevin Ratnasekera commented on GORA-512:
----------------------------------------
[~kamaci] I just noticed, IllegalStateException is caught and thrown/propagated
to higher layer as IOException. Are you suggesting, throwing a exception is
unnecessary for this case? We actually thought of doing this, if hbase store
read mapping file fails due to reason discussed here [1], throwing a exception
would help us write more testable code. ( We could test for exception thrown
from a unit test )
[1] https://github.com/apache/gora/pull/103
Regards
Kevin
> Fail at the time of error logging if KeyClass in gora-hbase-mapping is not
> the same as the one in the data bean
> ---------------------------------------------------------------------------------------------------------------
>
> Key: GORA-512
> URL: https://issues.apache.org/jira/browse/GORA-512
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-hbase
> Reporter: Nishadi Kirielle
> Assignee: Nishadi Kirielle
> Priority: Minor
>
> In the current implementation, when reading the HBase mapping file, if the
> HBase mapping file does not have a matching key class and name to the data
> bean, it only logs that information.[1] It does not fail at the time of
> detecting it. It fails only at the time of building the mapper [2] when it
> detects the table name is null. It will be better if it can fail at the time
> of detecting that mapping file is missing the corresponding class.
> [1].
> https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
> [2].
> https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
