Github user renato2099 commented on a diff in the pull request:

    https://github.com/apache/gora/pull/112#discussion_r127613910
  
    --- Diff: 
gora-orientdb/src/main/java/org/apache/gora/orientdb/store/OrientDBStore.java 
---
    @@ -0,0 +1,922 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.gora.orientdb.store;
    +
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +import java.util.Map;
    +import java.util.Properties;
    +import java.util.List;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.Calendar;
    +import java.util.Collection;
    +import java.util.TimeZone;
    +import java.util.Locale;
    +
    +import com.github.raymanrt.orientqb.query.Parameter;
    +import com.gitub.raymanrt.orientqb.delete.Delete;
    +import com.orientechnologies.orient.client.remote.OServerAdmin;
    +import com.orientechnologies.orient.core.db.OPartitionedDatabasePool;
    +import 
com.orientechnologies.orient.core.db.OPartitionedDatabasePoolFactory;
    +import com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx;
    +import com.orientechnologies.orient.core.db.record.OTrackedList;
    +import com.orientechnologies.orient.core.db.record.OTrackedMap;
    +import com.orientechnologies.orient.core.db.record.OTrackedSet;
    +import com.orientechnologies.orient.core.metadata.schema.OClass;
    +import com.orientechnologies.orient.core.metadata.schema.OType;
    +import com.orientechnologies.orient.core.record.impl.ODocument;
    +import com.orientechnologies.orient.core.sql.OCommandSQL;
    +import com.orientechnologies.orient.core.sql.query.OConcurrentResultSet;
    +import com.orientechnologies.orient.core.sql.query.OSQLSynchQuery;
    +import org.apache.avro.Schema;
    +import org.apache.avro.util.Utf8;
    +import org.apache.gora.orientdb.query.OrientDBQuery;
    +import org.apache.gora.orientdb.query.OrientDBResult;
    +import org.apache.gora.persistency.impl.BeanFactoryImpl;
    +import org.apache.gora.persistency.impl.DirtyListWrapper;
    +import org.apache.gora.persistency.impl.DirtyMapWrapper;
    +import org.apache.gora.persistency.impl.PersistentBase;
    +import org.apache.gora.query.PartitionQuery;
    +import org.apache.gora.query.Query;
    +import org.apache.gora.query.Result;
    +import org.apache.gora.query.impl.PartitionQueryImpl;
    +import org.apache.gora.store.impl.DataStoreBase;
    +import org.apache.gora.util.AvroUtils;
    +import org.apache.gora.util.ClassLoadingUtils;
    +
    +import javax.xml.bind.DatatypeConverter;
    +
    +import static com.github.raymanrt.orientqb.query.Projection.projection;
    +
    +/**
    + * {@link org.apache.gora.orientdb.store.OrientDBStore} is the primary 
class
    + * responsible for facilitating GORA CRUD operations on OrientDB documents.
    + */
    +public class OrientDBStore<K, T extends PersistentBase> extends 
DataStoreBase<K, T> {
    +
    +  public static final String DEFAULT_MAPPING_FILE = 
"/gora-orientdb-mapping.xml";
    +  private String ROOT_URL;
    +  private String ROOT_DATABASE_URL;
    +  private OrientDBStoreParameters orientDbStoreParams;
    +  private OrientDBMapping orientDBMapping;
    +  private OServerAdmin remoteServerAdmin;
    +  private OPartitionedDatabasePool connectionPool;
    +  private List<ODocument> docBatch = new ArrayList<>();
    --- End diff --
    
    QQ: would there be a reason to make this docBatch non-thread-safe? I am 
thinking if we ever use the same GoraConnection shared by multiple threads, 
this would have to change right? @lewismc  do you know if this would affect 
Nutch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to