[
https://issues.apache.org/jira/browse/GORA-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384641#comment-16384641
]
ASF GitHub Bot commented on GORA-530:
-------------------------------------
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/130
GORA-530: Removed redundant logging on several try/catch
Hi!
In this patch basically I removed the redundand "logging + throw" when the
log message is the same as in the exception.
Sorry for the mess of two pull requests :(
Please comment anything you find that don't convice you.
Thanks!
https://issues.apache.org/jira/browse/GORA-530
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alfonsonishikawa/gora GORA-530
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit b782a0a58ad5886604e1e80a051727dc7fe101f3
Author: Alfonso Nishikawa Muñumer <alfonso.nishikawa@...>
Date: 2018-03-03T11:52:04Z
GORA-530: Removed redundant logging on several try/catch
----
> Reinstate exception throwing at Query#execute()
> -----------------------------------------------
>
> Key: GORA-530
> URL: https://issues.apache.org/jira/browse/GORA-530
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Affects Versions: 0.8
> Reporter: Alfonso Nishikawa
> Assignee: Alfonso Nishikawa
> Priority: Minor
> Labels: query
> Fix For: 0.9
>
>
> When executing a query, the exceptions are being shadowed and the execution
> returns {{null}}.
> This makes any client to be ignorant of the cause, because it is only logged
> into the server.
> The objective is to reinstate the exception throwing, where the interface
> throws GoraException to make any client aware of the underlying problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
