[ https://issues.apache.org/jira/browse/GORA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400602#comment-16400602 ]
ASF GitHub Bot commented on GORA-266: ------------------------------------- Github user renato2099 commented on a diff in the pull request: https://github.com/apache/gora/pull/131#discussion_r174718062 --- Diff: gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneResult.java --- @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gora.lucene.query; + +import com.google.common.primitives.Ints; +import org.apache.gora.lucene.store.LuceneStore; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.Query; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.query.impl.ResultBase; +import org.apache.gora.store.DataStore; +import org.apache.lucene.document.Document; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.ScoreDoc; +import org.apache.lucene.search.SearcherManager; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashSet; +import java.util.Set; + +public class LuceneResult<K, T extends PersistentBase> extends ResultBase<K, T> { + + private ScoreDoc[] scoreDocs = null; + private final LuceneStore<K, T> store; + private String[] fields; + private int pos = 0; + private final SearcherManager searcherManager; + private IndexSearcher searcher; + + public LuceneResult(DataStore<K, T> dataStore, Query<K, T> query, --- End diff -- I am unsure how the other datastores are layed out, but if this is a LuceneResult, then we know that the dataStore is a LuceneStore, so it should take as a parameter a LuceneStore instead of a generic one. This will avoid doing the extra cast on line 59 and others. > Lucene datastore for Gora > ------------------------- > > Key: GORA-266 > URL: https://issues.apache.org/jira/browse/GORA-266 > Project: Apache Gora > Issue Type: New Feature > Components: gora-lucene > Reporter: Lewis John McGibbney > Assignee: Lewis John McGibbney > Priority: Minor > Labels: features > Fix For: 0.9 > > Attachments: GORA-266.patch > > > Sometimes we don't need to set up, administer, maintain and configure a > running solr server(s). > Sometime we just want to write to Lucene index files and read directly from > them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)