Hi Carlos, I have reviewed your PR [1] added some suggestions, please address them and let s get your work merged to master.
This is excellent work Carlos. Thank you for all the hard work you have put into in this summer. [1] https://github.com/apache/gora/pull/134 Regards Kevin On Mon, Jul 23, 2018 at 1:35 AM carlos muñoz <carlosr...@gmail.com> wrote: > Hi all. > > I am working on the changes that you guys suggested and other small > improvements. I hope I will be pushing my commits by Thursday. In the > meantime, I would like to update Gora's Wiki with details of the project > within the GSoC section [1], so I would highly appreciate you grant me > write access (my cwiki username: carlosrmng email: carlosr...@gmail.com). > > BTW, thanks so much for your feedback and support :D > > Regards, > > Carlos. > > [1] https://cwiki.apache.org/confluence/display/GORA/Google+Summer+of+Code > > > 2018-07-17 3:35 GMT-05:00 Alfonso Nishikawa <alfonso.nishik...@gmail.com>: > > > > > @Lewis, @Nishadi, wow you did a very thorough review, congrats =) I was > > liking your comments, but I guess is better just to say I subscribe all > > your coments (except one, but already commented :) > > > > Loooking forward those changes. Carlos, cheer up! :) > > Thanks! > > > > Regards, > > > > Alfonso > > > > > > > > 2018-07-15 7:05 GMT-01:00 Nishadi Kirielle <ndime...@gmail.com>: > > > >> Hi Carlos, > >> > >> This is great work..!!! > >> I have gone through your code and added some comments. Please have a > look > >> at them and let me know if you need further clarifications. > >> > >> Regards, > >> Nishadi > >> > >> On Sun, Jul 8, 2018 at 1:04 AM Lewis John Mcgibbney < > >> lewis.mcgibb...@gmail.com> wrote: > >> > >> > Hi Carlos, I’ll reciew by end of weekend this is an excellent effort > >> thank > >> > you. > >> > Lewis > >> > > >> > On Sat, Jul 7, 2018 at 07:30 carlos muñoz <carlosr...@gmail.com> > wrote: > >> > > >> >> Hi. > >> >> > >> >> Just a quick update of the project. > >> >> > >> >> I just have sent a PR [1] with the initial Ignite Backend > >> implementation. > >> >> All the tests are passing, but I would like to check the code in > other > >> to > >> >> improve it and catch possible errors. So I would highly appreciacte > if > >> you > >> >> review it. > >> >> Also, I would like to work on some documentation of the new backend. > >> >> Where does the Gora's website code live? and how can I edit it?. > >> >> > >> >> Best, > >> >> Carlos > >> >> > >> >> [1] https://github.com/apache/gora/pull/134 > >> >> > >> > -- > >> > > >> > *Lewis* > >> > Dr. Lewis J. McGibbney Ph.D, B.Sc > >> > *Skype*: lewis.john.mcgibbney > >> > > >> > > >> > > >> > > >> > > > > >
