djkevincr commented on a change in pull request #156: GORA 411 - Add 
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271628751
 
 

 ##########
 File path: 
gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBNativeStore.java
 ##########
 @@ -542,4 +542,9 @@ private Object getRangeKeyFromObj(T obj) throws 
IllegalArgumentException,
     return rangeKey;
   }
 
+       @Override
+       public boolean exists(K key) throws GoraException {
 
 Review comment:
   What is the reason overriding DataStoreBase.java exists(K key) here? You 
have already defined a default behavior at DataStoreBase class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to