djkevincr commented on issue #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#issuecomment-522917373 @chanakadkb Thank you for addressing my review comments. I ll let others to have a look as well. I do have a very minor concern on test running time which is - it takes around 13 minutes to complete on my local machine. Do you think further we can improve on this? ( Reducing embedded server startup/stop etc. ) As per the offline chat we had, lets separately address these concerns, hadoop-commons transitive dependency issue etc. We will also probably need documentation for gora site, adding hive datastore dependencies gora-tutorial, further improve on mapping files tests, mapreduce/flink/spark workloads tests to hive datastore, test cases which currently dissabled. You can address these in separate Jira tickets. I think we are are good to go with the initial version hive datastore. What's your thought @lewismc ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
