djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315996655
########## File path: pom.xml ########## @@ -1061,7 +1064,37 @@ <version>${flink.version}</version> <scope>compile</scope> </dependency> - + + <!-- Redis DataStore dependencies --> + <dependency> + <groupId>org.apache.gora</groupId> + <artifactId>gora-redis</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.gora</groupId> + <artifactId>gora-redis</artifactId> + <version>${project.version}</version> + <type>test-jar</type> + </dependency> + <dependency> + <groupId>org.redisson</groupId> + <artifactId>redisson-all</artifactId> + <version>${redisson.version}</version> + </dependency> + <dependency> + <groupId>org.apache.spark</groupId> + <artifactId>spark-core_2.11</artifactId> Review comment: Why you have added spark dependency again? This should be already defined in the parent pom. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services