[ 
https://issues.apache.org/jira/browse/GORA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alfonso Nishikawa updated GORA-633:
-----------------------------------
    Description: 
As per the docs KuduSession is not thread safe - 
https://kudu.apache.org/apidocs/org/apache/kudu/client/KuduSession.html
This variable is a shared variable and instantiated at class level. I noticed 
there are multiple operations you do on top of KuduSession instance. These can 
possibly fail at concurrency. You may need to create new session per each these 
operations you do on top it in datastore methods or add some pooling mechanism 
from your code. Please check on this whether we have complication at 
concurrency.

https://github.com/apache/gora/blob/master/gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java#L85

See complete thread at: 
https://github.com/apache/gora/pull/178#discussion_r316540236

Kudu list messages: 
https://lists.apache.org/thread.html/6d3d62ebc7ee2d76cc63e6f3c0d58fcd4addfedc7435e69519b5c447@%3Cuser.kudu.apache.org%3E

  was:
As per the docs KuduSession is not thread safe - 
https://kudu.apache.org/apidocs/org/apache/kudu/client/KuduSession.html
This variable is a shared variable and instantiated at class level. I noticed 
there are multiple operations you do on top of KuduSession instance. These can 
possibly fail at concurrency. You may need to create new session per each these 
operations you do on top it in datastore methods or add some pooling mechanism 
from your code. Please check on this whether we have complication at 
concurrency.

https://github.com/apache/gora/blob/master/gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java#L85

See complete thread at: 
https://github.com/apache/gora/pull/178#discussion_r316540236


> Make KuduSession thread safe for KuduStore
> ------------------------------------------
>
>                 Key: GORA-633
>                 URL: https://issues.apache.org/jira/browse/GORA-633
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-kudu
>    Affects Versions: 1.0
>            Reporter: Alfonso Nishikawa
>            Priority: Minor
>              Labels: gora-kudu
>
> As per the docs KuduSession is not thread safe - 
> https://kudu.apache.org/apidocs/org/apache/kudu/client/KuduSession.html
> This variable is a shared variable and instantiated at class level. I noticed 
> there are multiple operations you do on top of KuduSession instance. These 
> can possibly fail at concurrency. You may need to create new session per each 
> these operations you do on top it in datastore methods or add some pooling 
> mechanism from your code. Please check on this whether we have complication 
> at concurrency.
> https://github.com/apache/gora/blob/master/gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java#L85
> See complete thread at: 
> https://github.com/apache/gora/pull/178#discussion_r316540236
> Kudu list messages: 
> https://lists.apache.org/thread.html/6d3d62ebc7ee2d76cc63e6f3c0d58fcd4addfedc7435e69519b5c447@%3Cuser.kudu.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to