drazzib commented on issue #206: GORA-647 Use Testcontainers for MongoDB integration tests URL: https://github.com/apache/gora/pull/206#issuecomment-605498120 Hi @djkevincr! Thanks a lot for you feedback on my proposal for using Testcontainers on `gora-mongodb` module. I've just created a temporary `gora-testcontainers` job (copied from `gora-trunk`) on https://builds.apache.org/ to perform a functionnal check of this `GORA-647-test-containers-mongo` branch with real Apache Jenkins slaves. AFAICT from [Jenkins logs](https://builds.apache.org/view/E-G/view/Gora/job/gora-testcontainers/org.apache.gora$gora-mongodb/1/console), Docker containers seems properly supported :+1: ``` [INFO] --- maven-surefire-plugin:2.20:test (default-test) @ gora-mongodb --- [WARNING] The parameter forkMode is deprecated since version 2.14. Use forkCount and reuseForks instead. [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.gora.mongodb.filters.DefaultFactoryTest [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.566 s - in org.apache.gora.mongodb.filters.DefaultFactoryTest [INFO] Running org.apache.gora.mongodb.mapreduce.TestMongoStoreWordCount ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.014 s - in org.apache.gora.mongodb.mapreduce.TestMongoStoreWordCount [INFO] Running org.apache.gora.mongodb.mapreduce.TestMongoStoreCountQuery ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.375 s - in org.apache.gora.mongodb.mapreduce.TestMongoStoreCountQuery [INFO] Running org.apache.gora.mongodb.utils.TestBSONDecorator [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 s - in org.apache.gora.mongodb.utils.TestBSONDecorator [INFO] Running org.apache.gora.mongodb.store.TestMongoStore34 ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.838 s - in org.apache.gora.mongodb.store.TestMongoStore34 [INFO] Running org.apache.gora.mongodb.store.TestMongoMappingBuilder [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.382 s - in org.apache.gora.mongodb.store.TestMongoMappingBuilder [INFO] Running org.apache.gora.mongodb.store.TestMongoStore36 ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.844 s - in org.apache.gora.mongodb.store.TestMongoStore36 [INFO] Running org.apache.gora.mongodb.store.TestMongoMapping [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.201 s - in org.apache.gora.mongodb.store.TestMongoMapping [INFO] Running org.apache.gora.mongodb.store.TestMongoStore42 ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 69.541 s - in org.apache.gora.mongodb.store.TestMongoStore42 [INFO] Running org.apache.gora.mongodb.store.TestMongoStore40 ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.416 s - in org.apache.gora.mongodb.store.TestMongoStore40 [INFO] Running org.apache.gora.mongodb.authentications.PLAIN_AuthenticationTest ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 60.273 s - in org.apache.gora.mongodb.authentications.PLAIN_AuthenticationTest [INFO] Running org.apache.gora.mongodb.authentications.SCRAM_SHA_1_AuthenticationTest ?? Checking the system... ? Docker version is newer than 1.6.0 ? Docker environment has more than 2GB free ? File should be mountable ? Exposed port is accessible [INFO] Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.968 s - in org.apache.gora.mongodb.authentications.SCRAM_SHA_1_AuthenticationTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 321, Failures: 0, Errors: 0, Skipped: 0 ``` So I would like to proceed with merge of this branch. Are you okay with this ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
