Edward Capriolo wrote:
All,
Does the incubator have a policy on review + commit?
I have worked on other top level projects. Typically they have multiple
people on the project and have critical mass to make sure things get
reviewed.
Here not many are experienced with the code-base and may make other
hesitant to do a review.
I think it makes sense that if a Committer on Gossip does not get a review
in 1 day a self merge is ok.
Sean gave a nice long-form answer. My tl;dr opinion is "find something
that works for you". I've read many an argument on ctr and rtc;
ultimately, I think it depends on your community. Pick something,
document it, and see how it works out. :)
If this not acceptable I would like to established a pool of people that
are available for reviews and something like a soft SLA between us so we
know the worse case for action.
I'm kind of curious now if you would actually need any sort of IP
clearance just for review feedback. I believe as long as you have
straightforward rules that define who is "trusted", it would be fine.
In particular I am going to want to move things forward and I might
outstrip others availability.
