[
https://issues.apache.org/jira/browse/GOSSIP-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324462#comment-15324462
]
Dorian Ellerbe commented on GOSSIP-2:
-------------------------------------
Spacing - comma should go on the line above
https://github.com/apache/incubator-gossip/compare/master...edwardcapriolo:uri?expand=1#diff-3fdab6dbe84793d47aa0da8f75794c8cR50
Make 2000 a constant? What does it represent?
https://github.com/apache/incubator-gossip/compare/master...edwardcapriolo:uri?expand=1#diff-c712d16df34cf63e6a3068ed5b76fce8R72
Camel case - method name
https://github.com/apache/incubator-gossip/compare/master...edwardcapriolo:uri?expand=1#diff-eb31fe1f4339526e927458439493f192R48
Not on you, but I think we should add a refactoring task (ticket) to uniform
all objects that express time by changing them to Java Instant. The codebase is
still small enough where this is manageable.
> Replace connection information with host/port in to use uri
> -----------------------------------------------------------
>
> Key: GOSSIP-2
> URL: https://issues.apache.org/jira/browse/GOSSIP-2
> Project: Gossip
> Issue Type: Task
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
>
> As a user of gossip I want to be able to define the transport/connection
> settings using a URI instead of host/port.
> http://mail-archives.apache.org/mod_mbox/gossip-dev/201605.mbox/%3ccaenxbwwhrfhlbhst94i1k7-twwdf3s826nqjajmpynsauma...@mail.gmail.com%3E
> EC1: support gossip:udp://host:port or udp://host:port (see discussion above)
> EC2: remove host/port
> EC3: add uri (potentially stuff serialize this as a string)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
