Alright, there are some problems:
1) Check the output of `mvn apache-rat:check` on the source-release archive:
```
Unapproved licenses:
eclipse_template.xml
README.md
src/main/java/org/apache/gossip/manager/Clock.java
src/main/java/org/apache/gossip/manager/DataReaper.java
src/main/java/org/apache/gossip/manager/GossipCore.java
src/main/java/org/apache/gossip/manager/SystemClock.java
src/main/java/org/apache/gossip/manager/Transport.java
src/main/java/org/apache/gossip/manager/UdpUtil.java
src/main/java/org/apache/gossip/model/ActiveGossipOk.java
src/main/java/org/apache/gossip/model/Fault.java
```
The Java files must all have the ASL header. Would recommend that you
add the eclipse_template.xml and README.md to the exclusions list for
the apache-rat-plugin in pom.xml. Ideally, this should have triggered
when you did `mvn release:prepare release:perform`. I'd recommend
investigating why this didn't happen automatically.
2) It looks like you have no signatures on your GPG key. This
essentially means that there is no weight on the validity of your key
actually being yours'. I'm fuzzy as to whether or not this is a blocker,
but it would definitely be a good thing to make happen. I've
participated in a "virtual key-signing party" with Calcite which worked
out pretty well. Not in the traditional spirit for sure, but it was
better than nothing.
But, it is published, I was able to pull it down from pgp.mit.edu.
3) Need to add your pubkey to
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
(presently doesn't exist). Feel free to look at another project/podling
for an example. This lets people easily `curl https://dist.a.o./.../KEYS
| gpg --import` or similar from the trusted ASF location.
4) LICENSE/NOTICE both look standard. I forget the origins of Gossip, if
anything _should_ be included in the NOTICE file. Are there relevant
copyright notices which should be preserved from the pre-Apache days?
Overall, looks pretty good though!
Josh Elser wrote:
For the promotion to Central, this can happen after the Gossip PPMC and
IPMC votes both pass. When you "promote" the repository, it will be
automatically mirrored to Central for you.
The only manual steps will be updating the SVN dist.a.o repo.
P. Taylor Goetz wrote:
The official release needs to be a source code archive. Binaries are
optional.
The Apache parent Pom should take care of everything if you are only
packaging as a library.
-Taylor
On Nov 17, 2016, at 5:32 PM, Edward Capriolo<[email protected]>
wrote:
On Thu, Nov 17, 2016 at 4:27 PM, Josh Elser<[email protected]>
wrote:
Fantastic!
To be clear, I'll take a look tonight at https://repository.apache.org/
content/repositories/orgapachegossip-1000/org/apache/gossip/
gossip/0.1.0-incubating/gossip-0.1.0-incubating-source-release.zip
(assuming that is the official release artifact).
I assume that you also intend to publish the binary jar to Maven
Central
as well?
Edward Capriolo wrote:
Thanks,
I have closed the repository.
https://repository.apache.org/content/repositories/orgapachegossip-1000/
On Thu, Nov 17, 2016 at 12:30 PM, Josh Elser<[email protected]>
wrote:
Sure, happy to do that before an official VOTE thread!
Looks like you haven't closed the staging repository yet. This is
important for a few reasons.
* Closing the repository will trigger a number of automated release
checks
(notably around checksums and crypto signatures)
* Makes the staging repository immutable (you can presently
add/remove
files)
* Provides a nice URL to pass around :)
Can you log into https://repository.apache.org with your ASF creds,
click
on "Staging Repositories", find the "orgapachegossip-1000"
repository,
click the checkbox and then the "Close" button. This will trigger the
aforementioned checks and, upon successful close, will give you a URL
under
the Summary tab.
LMK if you get stuck
Edward Capriolo wrote:
Great infra solved that issue!
[INFO] Uploaded:
https://repository.apache.org/service/local/staging/deploy/m
aven2/org/apache/gossip/gossip/0.1.0-incubating/gossip-0.1.
0-incubating-sources.jar.asc
(836 B at 2.7 KB/sec)
[INFO] Uploading:
https://repository.apache.org/service/local/staging/deploy/m
aven2/org/apache/gossip/gossip/0.1.0-incubating/gossip-0.1.
0-incubating-javadoc.jar.asc
[INFO] 836/836 B
[INFO]
[INFO] Uploaded:
https://repository.apache.org/service/local/staging/deploy/m
aven2/org/apache/gossip/gossip/0.1.0-incubating/gossip-0.1.
0-incubating-javadoc.jar.asc
(836 B at 2.6 KB/sec)
[INFO] [INFO]
------------------------------------------------------------
------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO]
------------------------------------------------------------
------------
We have the artifacts deployed to staging now.
So the "tag" will not be pushed by the release
https://github.com/apache/incubator-gossip/compare/master...
edwardcapriolo:master.
And I will have to push it manually.
Does anyone want to review the artifacts produced?
Thanks,
Edward
On Mon, Nov 14, 2016 at 10:04 AM, Edward
Capriolo<[email protected]
wrote:
I created https://issues.apache.org/jira/browse/INFRA-12911
On Wed, Nov 9, 2016 at 5:14 PM, P. Taylor Goetz<[email protected]>
wrote:
I just tried and got the same error. Then I looked in the INFRA
JIRA
and
saw that we never requested Nexus access for the project.
Edward, are you comfortable doing that, or would you rather a
mentor
take
care of it?
-Taylor
On Nov 9, 2016, at 4:01 PM, Edward Capriolo<[email protected]>
wrote:
Thanks.
I have been running with:
mvn release:perform -Darguments='-Dmaven.test.skip=true'
The tests are a bit flaky as something is not shutting down
consistently. I
will look into that tonight.
On Wed, Nov 9, 2016 at 3:33 PM, Josh Elser<[email protected]>
wrote:
Let me know if you need help. I can try to find some time in the
evenings
to poke around, too.
Short answer to your question, Edward: `mvn release:prepare
release:perform` should stage a Maven repository on
repository.a.o
for
you.
Shouldn't have to upload anything there by hand.
P. Taylor Goetz wrote:
I’ll see if I can run the release procedure. I’ve been able to
release
other ASF projects.
-Taylor
On Nov 9, 2016, at 2:46 PM, Edward
Capriolo<[email protected]>
wrote:
Update;
I have ran mvn:release prepare which has produced this
"unmerged
tag"
https://github.com/apache/incubator-gossip/compare/master...
edwardcapriolo:master<https://github.com/apache/incubator-
gossip/compare/master...edwardcapriolo:master>
I have verified that signed artifacts are being released.
My keys are uploaded here:
http://people.apache.org/~ecapriolo/<http://people.apache.
org/~ecapriolo/>
mvn release:perform is not working
[INFO] Uploading: https://repository.apache.org/
service/local/staging/deploy/maven2/org/apache/gossip/gossip
/0.1.0-incubating/gossip-0.1.0-incubating.pom<https://
repository.apache.org/service/local/staging/deploy/maven2/
org/apache/gossip/gossip/0.1.0-incubating/gossip-0.1.0-incub
ating.pom>
[INFO] 4/10 KB
[INFO] 8/10 KB
[INFO] 10/10 KB
[INFO]
[INFO] [INFO] ------------------------------
------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------
------------------------------------------
[INFO] [INFO] Total time: 19.973s
[INFO] [INFO] Finished at: Wed Nov 09 14:31:25 EST 2016
[INFO] [INFO] Final Memory: 27M/397M
[INFO] [INFO] ------------------------------
------------------------------------------
[INFO] [WARNING] The requested profile "distribution" could
not be
activated because it does not exist.
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven
-deploy-plugin:2.8.2:deploy
(default-deploy) on project gossip: Failed to deploy artifacts:
Could not
transfer artifact org.apache.gossip:gossip:jar:0.1.0-incubating
from/to
apache.releases.https (https://repository.apache.org
/service/local/staging/deploy/maven2<https://repository.
apache.org/service/local/staging/deploy/maven2>): Failed to
transfer
file: https://repository.apache.org/
service/local/staging/deploy/m
aven2/org/apache/gossip/gossip/0.1.0-incubating/gossip-0.1.
0-incubating.jar<https://repository.apache.org/service/
local/staging/deploy/maven2/org/apache/gossip/gossip/0.1.
0-incubating/gossip-0.1.0-incubating.jar>. Return code is:
400 ->
[Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors,
re-run
Maven
with the -e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable
full debug
logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and
possible
solutions, please read the following articles:
[INFO] [ERROR] [Help 1] http://cwiki.apache.org/conflu
ence/display/MAVEN/MojoExecutionException<http://cwiki.
apache.org/confluence/display/MAVEN/MojoExecutionException>
I am poking around on http://repository.apache.org<h
ttp://repository.apache.org/> attempting to upload the
artifacts
directly (see attached picture)
I am not sure what the next step here is. is mvn release
supposed
to
work out of the box (I have my password in the settings.xml
file)
Or are the next steps manual?
Thanks,
Edward
On Thu, Oct 27, 2016 at 2:07 PM, P. Taylor Goetz<
[email protected]
<mailto:[email protected]>> wrote:
Done.
-Taylor
On Oct 27, 2016, at 11:58 AM, P. Taylor
Goetz<[email protected]
<mailto:
[email protected]>> wrote:
I’ll take care of it.
-Taylor
On Oct 27, 2016, at 11:43 AM, Edward Capriolo<
[email protected]
<mailto:[email protected]>> wrote:
The reply in the ticket is:
As you are a podling, please have someone from the IPMC
create
the
dist
directories you need.
On Thu, Oct 27, 2016 at 10:32 AM, Edward Capriolo<
[email protected]<mailto:[email protected]>>
wrote:
I filed a ticket to cover both:
https://issues.apache.org/jira/browse/INFRA-12833<https://
issues.apache.org/jira/browse/INFRA-12833>
I think this is the last thing we need.
Thanks,
Edward
On Sun, Oct 9, 2016 at 11:50 PM, Josh
Elser<[email protected]
<mailto:
[email protected]>> wrote:
Create a JIRA issue asking INFRA to create the SVN directories:
https://dist.apache.org/repos/dist/release/incubator/gossip<
https://dist.apache.org/repos/dist/release/incubator/gossip>
https://dist.apache.org/repos/dist/dev/incubator/gossip<http
s://dist.apache.org/repos/dist/dev/incubator/gossip>
dist/dev is a good location to stage RCs. Beware that
items
placed in
dist/release are automatically mirror'ed out. This should
only
contain
artifacts that have been approved via vote.
Check the permissions on your tilde-space. Not sure why
this
wouldn't
automatically happen.
Edward Capriolo wrote:
I have generated a key for signing following the
instructions
here:
http://www.apache.org/dev/release-signing.html<http://www.
apache.org/dev/release-signing.html>
I have created a pgp key with the requested strength.
http://keys.gnupg.net/pks/lookup?op=get&search=0x843E5702C87
8C988<
http://keys.gnupg.net/pks/lookup?op=get&search=0x843E5702C87
8C988>
I have created a public_html folder on people.apache.org<
http://people.apache.org/>, but I am not
seeing the content. http://people.apache.org/~ecapriolo<
http://people.apache.org/~ecapriolo>.
There are some steps that suggest I should put keys here:
https://dist.apache.org/repos/dist/release/incubator-gossip<
https://dist.apache.org/repos/dist/release/incubator-gossip>
I am not quite sure how to arrange that access.
P.Taylor any hints?
On Fri, Oct 7, 2016 at 3:47 PM, Edward Capriolo<
[email protected]<mailto:[email protected]>>
wrote:
I created:
https://issues.apache.org/jira/browse/GOSSIP-27<https://issu
es.apache.org/jira/browse/GOSSIP-27>
Some of the items I have to handle but others are
free to
take
on
/send
PR
for the remaining.
On Fri, Oct 7, 2016 at 3:43 PM, chandresh pancholi<
[email protected]<mailto:
chandreshpancholi007@g
mail.com>> wrote:
Sure Ed.
Can you create the ticket?
On Sat, Oct 8, 2016 at 1:07 AM, Edward Capriolo<
[email protected]<mailto:[email protected]>>
wrote:
Good catch.
There are a few issues I see.
The first is the maven instructions at the bottom,
The second is that the build link is wrong. it
should be
# Apache Gossip 
The third is that some of the code examples are slightly
dated.
Lets open up a ticket to track this and the things
p.taylor
mentions.
On Fri, Oct 7, 2016 at 3:25 PM, chandresh pancholi<
[email protected]<mailto:
chandreshpancholi007@g
mail.com>> wrote:
We need to change same in project's readme.md<
http://readme.md/
.
On Sat, Oct 8, 2016 at 12:40 AM, Edward Capriolo<
[email protected]<mailto:[email protected]>>
wrote:
You might be looking at the wrong project:
https://github.com/edwardcapriolo/incubator-gossip/blob/
<htt
ps://github.com/edwardcapriolo/incubator-gossip/blob/>
master/pom.xml
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>RELEASE</version>
</parent>
<groupId>org.apache.gossip</groupId>
<artifactId>gossip</artifactId>
<name>gossip</name>
A few people seem to be confused because the
pre-fork
code
is
also
in
my
github.
On Fri, Oct 7, 2016 at 2:55 PM, P. Taylor Goetz<
[email protected]<mailto:[email protected]>>
wrote:
I would change the groupId to org.apache.gossip. I’d
have
to
check,
but I
think Nexus has rules in place that enforce that,
so it’s
probably
best
to
just go ahead.
-Taylor
On Oct 7, 2016, at 2:52 PM, chandresh pancholi<
[email protected]<mailto:
chandreshpancholi007@g
mail.com>> wrote:
+1 for release.
Concern
Right now groupId on github says io.teknek.
Will it
change to
org.apache.gossip in first release?
If it changes then we have to remove io.teknek from
readme.md<http://readme.md/>
Thanks
On Fri, Oct 7, 2016 at 11:55 PM, P. Taylor Goetz<
[email protected]<mailto:[email protected]>>
wrote:
The typical process is to have a DISCUSS thread
before
and
official
VOTE
thread, but I assume that was the intent here.
I’m +1 for moving forward with a release. Here
are some
links
to
some
light reading about the process [1][2].
A quick check of the gossip repo reveals the
following
that
need
to
be
addressed before release:
- DISCLAIMER file needs to be added.
- NOTICE file needs to added (see [3] for the
procedure)
- KEYS file needs to be created (see [4] for more
light
reading on
signing
releases)
The release manager will also need an account on
repository.apache.org<http://repository.apache.org/>
(ASF’s
Nexus instance).
It would also be good, but not required, for the
signing key
to be
linked
to the Apache web of trust.
Edward, can I assume you are going to be the release
manager
for
the
first
release? If you need any help, feel free to ask.
-Taylor
[1] http://incubator.apache.org/gu
ides/releasemanagement.html<ht
tp://incubator.apache.org/guid
es/releasemanagement.html
[2] http://incubator.apache.org/in
cubation/Incubation_Policy<htt
p://incubator.apache.org/incub
ation/Incubation_Policy
.
html#Releases
[3] http://www.apache.org/legal/sr
c-headers.html#notice
<
http://www.apache.org/legal/src-headers.html#notice>
[4]
http://www.apache.org/dev/release-signing.html<
http://www.apache.org/dev/release-signing.html>
On Oct 7, 2016, at 3:26 AM, Edward Capriolo<
[email protected]<mailto:[email protected]>>
wrote:
With the additions of:
https://issues.apache.org/jira/browse/GOSSIP-21<
https://issues.apache.org/jira/browse/GOSSIP-21>
https://issues.apache.org/jira/browse/GOSSIP-26<
https://issues.apache.org/jira/browse/GOSSIP-26>
Apache Gossip has the the ability to create
peer to
peer
systems
and
share
user defined data between them. Those capabilities
prompts
me
to
call
a
vote for the first release of Apache Gossip.
The current pom tag is 0.1.0-incubating so I
think we
should
call
the
release version 0.2.0-incubating.
My vote +1 (binding).
Thank you,
Edward
(Thank you mentors for good nudging :)
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:[email protected]<mailto:
Email-id%3Ac
[email protected]>
Contact:08951803660
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:[email protected]<mailto:
Email-id%3Ac
[email protected]>
Contact:08951803660
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:[email protected]<mailto:
Email-id%3Ac
[email protected]>
Contact:08951803660
"I assume that you also intend to publish the binary jar to Maven
Central
as well?"
Currently the project pom does not build an assembly. We could be
build an
assembly and include that tin the release process although I do not see
many people deploying gossip as a stand alone.
Maybe we can go over the next steps.
Push the tag to git: (not sure of exact command but I will figure it
out)
Push the release to maven-central (How do we do that being maven release
only pushes to a staging repo?)
Upload to SVN ?
Mirror ?
