[jira] [Commented] (GOSSIP-63) Implement Crdt G-Counter

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/GOSSIP-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901237#comment-15901237
 ] 

ASF GitHub Bot commented on GOSSIP-63:
--------------------------------------

Github user edwardcapriolo commented on a diff in the pull request:

    https://github.com/apache/incubator-gossip/pull/41#discussion_r104912672
  
    --- Diff: src/main/java/org/apache/gossip/crdt/CrdtModule.java ---
    @@ -42,6 +42,13 @@
       @JsonIgnore abstract boolean isEmpty();
     }
     
    +abstract class GrowOnlyCounterMixin{
    +  @JsonCreator
    +  GrowOnlyCounterMixin(@JsonProperty("myID") String myID, 
@JsonProperty("counters") Map<String , Long> count){ }
    --- End diff --
    
    I do not think we should serialize myId. The reason: if one node sets myID 
and sends that data to another system myId is now incorrect. We need some way 
to properly hydrate this.


> Implement Crdt G-Counter
> ------------------------
>
>                 Key: GOSSIP-63
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-63
>             Project: Gossip
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)