Welcome to the Gossip community Mirage! Looks like you and Edward are working together well on scoping out the work. Well done.
-Taylor > On Mar 10, 2017, at 7:00 PM, Edward Capriolo <[email protected]> wrote: > > On Fri, Mar 10, 2017 at 4:46 PM, Mirage Abeysekara <[email protected]> > wrote: > >> My apache-jira id is mirage20 >> >> >> *Mirage Abeysekara* >> Undergraduate >> Computer Science and Engineering >> University of Moratuwa >> Twitter: https://twitter.com/MiRAGECreator >> GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara >> >>> On 10 March 2017 at 18:23, Edward Capriolo <[email protected]> wrote: >>> >>> Thanks, >>> >>> What is your apache-jira id? >>> >>> On Thu, Mar 9, 2017 at 3:49 AM, Mirage Abeysekara < >> [email protected] >>>> >>> wrote: >>> >>>> Hi Edward, >>>> >>>> I created a new PR with proper formatting >>>> https://github.com/apache/incubator-gossip/pull/42 >>>> >>>> "pub sub on data objects" looks great. Can you please provide mode >>> details >>>> (or example) on that issue? >>>> Is it like adding CRDT data change events for a same node? or between >>>> nodes? >>>> >>>> Thanks. >>>> >>>> *Mirage Abeysekara* >>>> Undergraduate >>>> Computer Science and Engineering >>>> University of Moratuwa >>>> Twitter: https://twitter.com/MiRAGECreator >>>> GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara >>>> >>>> On 9 March 2017 at 12:11, Edward Capriolo <[email protected]> >> wrote: >>>> >>>>> On Thu, Mar 9, 2017 at 12:43 AM, Mirage Abeysekara < >>>>> [email protected]> >>>>> wrote: >>>>> >>>>>> Hello Edward, >>>>>> >>>>>> I updated the PR based on your review. >>>>>> >>>>>> I didn’t understand what you meant. You mean all the CRDT tickets >>> under >>>>>> GSoC are assigned for someone or ticket that I tried to fix? >>>>>> >>>>>> Thanks. >>>>>> >>>>>> *Mirage Abeysekara* >>>>>> Undergraduate >>>>>> Computer Science and Engineering >>>>>> University of Moratuwa >>>>>> Twitter: https://twitter.com/MiRAGECreator >>>>>> GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara >>>>>> >>>>>> On 8 March 2017 at 21:30, Edward Capriolo <[email protected]> >>>> wrote: >>>>>> >>>>>>> Mirage, >>>>>>> >>>>>>> Also something important to note: Please try to not to work on >> any >>>> more >>>>>>> tickets labeled GSOC yet. We already have someone interested in >>> doing >>>>>> GSOC >>>>>>> (with gossip) and we sized that work so there would be >> substantial >>>> work >>>>>> for >>>>>>> that one person to do during the GSOC period. We need to slice >> off >>>> more >>>>>>> work likely if we end up with two GSOC applicants. >>>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> On Wed, Mar 8, 2017 at 8:29 AM, Edward Capriolo < >>>> [email protected] >>>>>> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Mar 8, 2017 at 12:01 AM, Mirage Abeysekara < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> I'm Mirage Abeysekara, a final year Computer Science and >>>> Engineering >>>>>>>>> undergraduate from University of Moratuwa, Sri Lanka. I am >>>>> interested >>>>>> in >>>>>>>>> contributing to the Apache Gossip by adding CRDT >>> implementations. >>>>> As a >>>>>>>>> start, I implemented the sample grow-only counter >> (GOSSIP-63)[1] >>>> by >>>>>>>>> refering the Wikipedia[2]. I created a PR for git mirror[3]. >> It >>>>> would >>>>>> be >>>>>>>>> great if you can give me some feedback regarding the G-Counter >>>>>>>>> implementation. >>>>>>>>> >>>>>>>>> [1] https://issues.apache.org/jira/browse/GOSSIP-63 >>>>>>>>> [2] >>>>>>>>> https://en.wikipedia.org/wiki/Conflict-free_replicated_data_ >>>>>>>>> type#State-based_increment-only_counter >>>>>>>>> [3] https://github.com/apache/incubator-gossip/pull/41 >>>>>>>>> <https://github.com/apache/incubator-gossip/pull/41> >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> *Mirage Abeysekara* >>>>>>>>> Undergraduate >>>>>>>>> Computer Science and Engineering >>>>>>>>> University of Moratuwa >>>>>>>>> Twitter: https://twitter.com/MiRAGECreator >>>>>>>>> GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara >>>>>>>>> >>>>>>>> >>>>>>>> Hello Mirage, >>>>>>>> >>>>>>>> Thank you for the addition. Welcome! I have already done a >> first >>>> pass >>>>>>>> review for you on the g-counter work. >>>>>>>> >>>>>>>> We have set aside some of these tickets for Maxim (another GSOC >>>>>>>> contributor). Make sure you have done what you need to do on >> your >>>> end >>>>>> for >>>>>>>> GSOC. I also filled out a mentor request yesterday and we have >> to >>>>> find >>>>>> a >>>>>>>> mentor for you. >>>>>>>> >>>>>>>> Thanks again, >>>>>>>> Edward >>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> I didn’t understand what you meant. You mean all the CRDT tickets >> under >>>>> GSoC are assigned for someone or ticket that I tried to fix? >>>>> >>>>> (You already started on the gcounter ticket and are doing great work >>>> there >>>>> so we should finish that.) >>>>> >>>>> Yes, the tickets under the CRDT umbrella are part of someone >>>>> else's proposal for GSOC. It would be best if you found some issues >> you >>>> are >>>>> interested in or we created some new issues that are earmarked for >> you. >>>> We >>>>> have had a few people show interest in the project recently which is >>>> great, >>>>> but we need to make sure the issues are sized correctly to keep >> people >>>>> busy. >>>>> >>>>> Would you consider picking up pub sub >>>>> https://issues.apache.org/jira/browse/GOSSIP-55?jql= >>>>> text%20~%20%22pub%20sub%22%20and%20project%20%3D%20gossip >>>>> for a GSOC proposal? >>>>> >>>> >>> >> > > Thank you. > You are now a contributor to Gossip in Jira. You can assign yourself tasks. > Great work. I played with the gcounters today and they look good. > > We have a little example app. I added gcounter support to it. > > https://github.com/apache/incubator-gossip/compare/master...edwardcapriolo:GOSSIP-73?expand=1 > > It is more rewarding to launch a few instances and watch the counters sync > around. If you want to review GOSSIP-73 that ticket you can comment on jira > with a +1 if you think it makes sense!
