[
https://issues.apache.org/jira/browse/GOSSIP-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995603#comment-15995603
]
ASF GitHub Bot commented on GOSSIP-85:
--------------------------------------
Github user edwardcapriolo commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/50#discussion_r114645239
--- Diff:
gossip-base/src/main/java/org/apache/gossip/transport/AbstractTransportManager.java
---
@@ -77,11 +75,9 @@ public void shutdown() {
@Override
public void startActiveGossiper() {
- activeGossipThread.init();
+ activeGossipThread.init();
}
@Override
- public void startEndpoint() {
- gossipThreadExecutor.execute(passiveGossipThread);
- }
+ public abstract void startEndpoint();
--- End diff --
It is a nice hook to start the thread outside of the constructor so it
seems useful. Generally we have tried to avoid anything in the constructor that
could throw and favored init()
> UDP Server moved to sub module
> ------------------------------
>
> Key: GOSSIP-85
> URL: https://issues.apache.org/jira/browse/GOSSIP-85
> Project: Gossip
> Issue Type: Improvement
> Reporter: Edward Capriolo
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
