[
https://issues.apache.org/jira/browse/GOSSIP-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036874#comment-16036874
]
ASF GitHub Bot commented on GOSSIP-86:
--------------------------------------
GitHub user Terry-Weymouth opened a pull request:
https://github.com/apache/incubator-gossip/pull/52
GOSSIP-86 Examples in separate module - Added Readme.
I was bothered by the number of white-space changes to the original source
code, but after careful examination, it turns out that most of these are the
result of formatting the code with the given Eclipse template in place. So, I
assume that they are ok.
As suggested, added note to top level README.md and added code to
(optionally) clear screen on each iteration - makes output easier to follow.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Terry-Weymouth/incubator-gossip GOSSIP-86
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gossip/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 9c9d96e564eca1513a9776b9eba24d52787500d2
Author: Terry Weymouth <[email protected]>
Date: 2017-05-29T13:16:32Z
GOSSIP-86 Examples in separate module - Added Readme.
----
> Examples in separate module - Update Readme.
> --------------------------------------------
>
> Key: GOSSIP-86
> URL: https://issues.apache.org/jira/browse/GOSSIP-86
> Project: Gossip
> Issue Type: New Feature
> Affects Versions: 0.1.3
> Reporter: Terry Weymouth
> Assignee: Terry Weymouth
> Priority: Minor
> Labels: documentation, newbie
> Fix For: 0.1.3
>
>
> Drawing on the tutorial videos and "just fooling around" I'm proposing the
> create a README.md for the gossip examples package. Also, to make set up and
> running of the examples more obvious and clearer to follow, I'm proposing
> that the examples be moved to a separate module: see, for example the usage
> of the gossip-examples module in
> https://github.com/gdusbabek/incubator-gossip/tree/gossip_manager_coupling
> (which I draw on for information - especially copying the pom.xml file -
> Thanks Gary!)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
