[
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053300#comment-16053300
]
ASF GitHub Bot commented on GOSSIP-65:
--------------------------------------
Github user edwardcapriolo commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/54#discussion_r122598947
--- Diff: gossip-base/src/main/java/org/apache/gossip/crdt/LWWSet.java ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gossip.crdt;
+
+import org.apache.gossip.manager.Clock;
+import org.apache.gossip.manager.SystemClock;
+
+import java.util.*;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
--- End diff --
Documentation here. You should at least mentioned that this implementation
is bias for add since isPresent ranks add > remove
> Implement crdt LWW-Element-Set
> -------------------------------
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
> Issue Type: New Feature
> Reporter: Edward Capriolo
> Assignee: Maxim Rusak
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
