[ 
https://issues.apache.org/jira/browse/GOSSIP-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058051#comment-16058051
 ] 

ASF GitHub Bot commented on GOSSIP-88:
--------------------------------------

Github user edwardcapriolo commented on a diff in the pull request:

    https://github.com/apache/incubator-gossip/pull/55#discussion_r123341026
  
    --- Diff: 
gossip-itest/src/test/java/org/apache/gossip/SharedDataReplicationControlTest.java
 ---
    @@ -0,0 +1,114 @@
    +/*
    --- End diff --
    
    More unit tests less integreation tests :) GEnerally if you need an 
end-to-end test with 100+ lines of code to tests 20 lines of codes you are 
better off with smaller tests.


> Data Replication Control
> ------------------------
>
>                 Key: GOSSIP-88
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-88
>             Project: Gossip
>          Issue Type: New Feature
>            Reporter: Mirage Abeysekara
>            Assignee: Mirage Abeysekara
>              Labels: gsoc2017
>
> Currently shared data and per node data get replicated on all nodes. It is 
> better to have data replication control with following requirements
> * Data should never get replicated
> * Data should only get replicated on given set of nodes
> * Data should only replicated on its Datacenter
> In implementation the AbstractActiveGossiper is currently sending its shared 
> data and per node data to a randomly selected live member. To control this 
> replication we add a new property to the message (eg: SharedDataMessage  has 
> a property which says whether this datum need to be replicated or not with a 
> given member.) and use that property in the AbstractActiveGossiper when 
> sending data to a member.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to