You can check this: https://github.com/apache/incubator-gossip/pull/56 I changed +10000 to Long.MAX_VALUE. It can't fail
26.06.2017, 03:28, "Русак Максим" <[email protected]>: > Ok, few minutes and I'll do them right > > 26.06.2017, 03:14, "Edward Capriolo" <[email protected]>: >> The tests are flakey on my machine thry fail every other time in current >> state. >> >> On Sunday, June 25, 2017, Русак Максим <[email protected]> wrote: >> >>> Why call clock.nanotime() once? >>> If you want to make tests more deterministic and don't rely on assumption >>> that between two commands there will be less time than 100000 nanoseconds. >>> Then it's good intention, I think it makes tests less intuitive, but it's >>> good. >>> But your changes don't achieve this goal. For example: >>> >>> map.put(25, new LWWSet.Timestamps(nano + 100000 + 100000, 0)); >>> lww = new LWWSet<>(map); >>> lww = lww.remove(25); >>> Assert.assertEquals(lww, new LWWSet<>(25)); >>> >>> lww.remove get clock.nanotime() so you rely that nano + 100000 + 100000 >= >>> clock.nanotime() it isn't fair. >> >> -- >> Sorry this was sent from mobile. Will do less grammar and spell check than >> usual.
