On Sun, 2008-10-26 at 08:13 +0100, Hans Dockter wrote:
> On Oct 25, 2008, at 12:19 PM, Russel Winder wrote:
> 
> > There appears to be no obvious error message when "gradle  
> > userguide" is
> > run on the Gradle source and pdflatex is not installed.  Gradle  
> > appears
> > to terminate with success but no PDF is produced (obviously :-)
> 
> We don't want to let the build fail if users have not latex  
> installed. So we check if it is installed, otherwise we skip the  
> task. If you run the build with -i you would get a message on this.

That is no problem per se, but there needs to be notification that the
task has done nothing.  Currently there is nothing to distinguish
success from done nothing -- and this leads to incorrect expectations of
what output should exist.

Basically if pdflatex is not present then any attempt to complete
userguide must indicate that the task failed.  Automated and silent
skipping is the wrong thing to do for what is actually a broken build.

I know you say use the -i option, but I think there needs to be
notification always except when -q is used.

-- 
Russel.
====================================================
Dr Russel Winder                 Partner

Concertant LLP                   t: +44 20 7585 2200, +44 20 7193 9203
41 Buckmaster Road,              f: +44 8700 516 084
London SW11 1EN, UK.             m: +44 7770 465 077

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to