Hi Rafa,

On Nov 18, 2008, at 8:46 PM, Rafael Serrano wrote:


Hi all,

We are about to release a scaffolding tool with the next release of the Loom project ( http://loom.extrema-sistemas.org ) that creates a eclipse
project structure based on gradle.

Cool :)

I attach the
http://www.nabble.com/file/p20566832/build.gradle build.gradle  file
that would be generated.

Everything works fine, but we wanted to ask the gradle list for comments
regarding the build file. If someone wanted to discuss about it
(additions / removals / optimizations are most welcome!) or wanted to
test the scaffolding tool before the release, please drop me a line
(on-list or off-list, as you prefer).

I had a quick look and it looks good to me. But I had no time to think myself into the problem space you are trying to solve, so I might have missed something.

A couple of comments:

1.) task("eclipse").doFirst {
        task("gen-lib").execute()
}

Instead of task("eclipse") you can also write eclipse. And instead of executing you could create a dependsOn relation. The above would turn into:

eclipse.dependsOn "gen-lib"

2.) There is a predefined dir which is used automatically by the war plugin. The property is called webAppDir and defaults to src/main/ webApp. If you don't like the location you can say: webAppDirName = 'env'. This name is relative to the src dir. That should spare you the:

archive_war {
        fileSet(dir: webappDir)
}

3.) Instead of try {
                this["${appServer}Home"]
        } catch(MissingPropertyException e) {
// println "The property ${appServer}Home has not been set. Trying to use $envName"
                this["${appServer}Home"] = getEnv(envName)
        }

You can use the hasProperty method: if (hasProperty("${appServer} Home")) { ... }

- Hans

--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email



Reply via email to