Hi Johannes,
cool to see this finally working.

Am 03.02.11 23:29, schrieb Johannes Buehler:
> Hi,
> finally at the last hackergarten we made a big step forward to a final
> version of the findbugs plugin for the gradle code-quality check. But
> unfortunatelly there are few issues i was able to solve by myself in a
> reasonable time. So it would be glad if some of you could give me a hint
> on the following two issues:
>
>  - I defined a findbugs configuration within the plugin in order be able
> to pass the findbugs classpath to the findbugs ant task. This results in
> the need to declare a findbugs configuration in the buildscript, which
> is of course not a good thing.
I guess the findbugs plugin has two dependencies (
":findbugs:findbugs:1.0.0" and :findbugs:findbugs-ant:1.0.0") right?
Keeping the dependency declaration within your buildfile has two
advantages I think:
1. the user can decide which version of findbugs is used (like the
groovy configuration in the groovy plugin"
2. the findbugs core jar is about 1mb. Adding this lib to the shipped
gradle bundle will blow up the size of distribution
>  
>
>  - The findbugs task extends SourceTask, would the AbstractCompile be
> more appropriate, cause findbugs uses the bytecode for the analysis.
>
> The source code is checked in the findbugs branch in the code-quality
> plugin subproject on
> https://github.com/jonnybbb/gradle/commits/findbugs 
>
>
> Thanks
> Johannes
>
>  
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>     http://xircles.codehaus.org/manage_email
>

-- 
------------------------------------
Rene Groeschke

[email protected]
http://www.breskeby.com
http://twitter.com/breskeby
------------------------------------


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to