Oh I see. Thanks for info! Our options:
1. We pull it. Apparently the current announce plugin does not work with twitter any more. Hence the proposed implementation is still an improvement. Even though it requires an extra step to preserve the authentication information. 2. We decide that the interactive step is against Gradle philosophy and close the request without pulling it. I'm ok with #1. If there are no strong objections I'll execute it at some point in future :) Cheers! Szczepan On Tue, Jul 5, 2011 at 6:29 PM, Peter Niederwieser <[email protected]> wrote: > > Szczepan Faber wrote: >> >> In some near future I'll merge/test/clean/etc this pull request: >> https://github.com/gradle/gradle/pull/7 >> >> Let me know if you have any questions / issues with this pull request :) >> > > We didn't pull the patch because we weren't sure about the approach. From > what I remember, the authentication procedure introduced by the patch > requires an interactive step, which isn't feasible for, say, a build server. > > -- > Peter Niederwieser > Principal Engineer, Gradleware > http://gradleware.com > Creator, Spock Framework > http://spockframework.org > Blog: http://pniederw.wordpress.com > Twitter: @pniederw > > > -- > View this message in context: > http://gradle.1045684.n5.nabble.com/pull-request-merge-tp4553016p4553854.html > Sent from the gradle-dev mailing list archive at Nabble.com. > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > -- Szczepan Faber Principal engineer@gradleware Lead@mockito --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
