On 24/08/2011, at 5:42 PM, Luke Daley wrote: > What's happening to Instantiator?
I've split the 2 concepts, so that ClassGenerators don't need to know how to instantiate things. Most code should now just use an Instantiator to create the things they need. When they ask for an Instantiator, they'll get one that happens to be backed by a ClassGenerator, but which may do other stuff (say, firing events or doing some dependency injection or whatever). > > Begin forwarded message: > >> From: [email protected] >> Subject: [gradle-scm] [gradle/gradle] 4b5563: ClassGenerator no longer >> extends Instantiator >> Date: 24 August 2011 7:01:41 AM GMT+01:00 >> To: [email protected] >> Reply-To: [email protected] >> >> Branch: refs/heads/master >> Home: https://github.com/gradle/gradle >> >> Commit: 4b5563a85856a515cd672ebab73ae39c8a5c4593 >> >> https://github.com/gradle/gradle/commit/4b5563a85856a515cd672ebab73ae39c8a5c4593 >> Author: adammurdoch <[email protected]> >> Date: 2011-08-23 (Tue, 23 Aug 2011) >> >> Changed paths: >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/AbstractClassGenerator.java >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/ClassGenerator.java >> A >> subprojects/core/src/main/groovy/org/gradle/api/internal/ClassGeneratorBackedInstantiator.java >> A >> subprojects/core/src/main/groovy/org/gradle/api/internal/DirectInstantiator.java >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/ReflectiveNamedDomainObjectFactory.java >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/project/GlobalServicesRegistry.java >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/project/TopLevelBuildServiceRegistry.java >> M >> subprojects/core/src/main/groovy/org/gradle/groovy/scripts/DefaultScriptCompilerFactory.java >> M >> subprojects/core/src/main/groovy/org/gradle/testfixtures/internal/GlobalTestServices.java >> R subprojects/core/src/main/groovy/org/gradle/util/DirectInstantiator.java >> M subprojects/core/src/main/groovy/org/gradle/util/ServiceLocator.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/AbstractClassGeneratorTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/AbstractNamedDomainObjectContainerTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/AsmBackedClassGeneratorTest.java >> A >> subprojects/core/src/test/groovy/org/gradle/api/internal/ClassGeneratorBackedInstantiatorTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/DefaultNamedDomainObjectSetTest.java >> A >> subprojects/core/src/test/groovy/org/gradle/api/internal/DirectInstantiatorTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/GroovySourceGenerationBackedClassGeneratorTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/NestedConfigureAutoCreateNamedDomainObjectContainerSpec.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/DefaultConfigurationHandlerTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/DefaultRepositoryHandlerTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/project/DefaultProjectTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/project/GlobalServicesRegistryTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/project/TopLevelBuildServiceRegistryTest.java >> R >> subprojects/core/src/test/groovy/org/gradle/util/DirectInstantiatorTest.groovy >> M subprojects/core/src/test/groovy/org/gradle/util/HelperUtil.groovy >> >> Log Message: >> ----------- >> ClassGenerator no longer extends Instantiator >> >> >> Commit: 045a0e41d783714e2ef467d4c2b11cbf65f56a08 >> >> https://github.com/gradle/gradle/commit/045a0e41d783714e2ef467d4c2b11cbf65f56a08 >> Author: adammurdoch <[email protected]> >> Date: 2011-08-23 (Tue, 23 Aug 2011) >> >> Changed paths: >> M >> subprojects/core/src/main/groovy/org/gradle/api/internal/AbstractClassGenerator.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/NestedConfigureAutoCreateNamedDomainObjectContainerSpec.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/dependencies/DefaultClientModuleFactoryTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/dependencies/DefaultProjectDependencyFactoryTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/dependencies/ModuleDependencyFactoryTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/dependencies/SelfResolvingDependencyFactoryTest.java >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/project/DefaultProjectTest.groovy >> M >> subprojects/core/src/test/groovy/org/gradle/api/internal/project/ProjectInternalServiceRegistryTest.java >> M >> subprojects/plugins/src/test/groovy/org/gradle/api/internal/tasks/DefaultSourceSetContainerTest.java >> >> Log Message: >> ----------- >> AbstractClassGenerator no longer implements Instantiator >> >> >> Compare: https://github.com/gradle/gradle/compare/3575ccc...045a0e4 >> >> <hr/> >> <p> >> To unsubscribe from this list please visit: >> </p> >> <p> >> <a >> href="http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email</a> >> > > -- > Luke Daley > Principal Engineer, Gradleware > http://gradleware.com > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > -- Adam Murdoch Gradle Co-founder http://www.gradle.org VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting http://www.gradleware.com
