On 16/09/2011, at 7:54 AM, [email protected] wrote: > Branch: refs/heads/master > Home: https://github.com/gradle/gradle > > Commit: f53cf79f4c23e3ce3fa8061ef042940fb4b88fa6 > > https://github.com/gradle/gradle/commit/f53cf79f4c23e3ce3fa8061ef042940fb4b88fa6 > Author: daz <[email protected]> > Date: 2011-09-15 (Thu, 15 Sep 2011) > > Changed paths: > M > subprojects/core-impl/src/main/groovy/org/gradle/api/internal/artifacts/repositories/layout/GradleRepositoryLayout.java > M > subprojects/core-impl/src/main/groovy/org/gradle/api/internal/artifacts/repositories/layout/MavenRepositoryLayout.java > M > subprojects/core/src/main/groovy/org/gradle/api/artifacts/dsl/RepositoryHandler.java > M > subprojects/core/src/main/groovy/org/gradle/api/artifacts/repositories/IvyArtifactRepository.java > M > subprojects/core/src/main/groovy/org/gradle/api/internal/artifacts/dsl/DefaultRepositoryHandler.java > M > subprojects/core/src/test/groovy/org/gradle/api/internal/artifacts/dsl/DefaultRepositoryHandlerTest.groovy > M > subprojects/docs/src/samples/userguide/artifacts/defineRepository/build.gradle > M > subprojects/integ-test/src/integTest/groovy/org/gradle/integtests/ArtifactDependenciesIntegrationTest.groovy > M > subprojects/integ-test/src/integTest/groovy/org/gradle/integtests/maven/MavenRemoteDependencyResolutionIntegrationTest.groovy > M > subprojects/integ-test/src/integTest/resources/org/gradle/integtests/maven/MavenRemoteDependencyResolutionIntegrationTest/canResolveDependenciesFromMultipleMavenRepositories/build.gradle > M > subprojects/integ-test/src/integTest/resources/org/gradle/integtests/maven/MavenRemoteDependencyResolutionIntegrationTest/shared/projectWithMavenSnapshots.gradle > > Log Message: > ----------- > Made the api of mavenCentral and mavenRepo consistent with repositories.maven > - Deprecated mavenCentral.urls and mavenRepo.urls. > - Supported syntax: > repositories { > mavenCentral artifactUrls: [...]
Thinking about it, we should just deprecate mavenCentral(Map). Maven central is maven central, and if you want to tweak the repository, you can always tweak the return value from mavenCentral(). Or, if we keep mavenCentral(Map), we should add mavenCentral(Closure). > mavenRepo url: ..., artifactUrls: [...] I wonder if the distinction between MavenArtifactRepository.url and artifactUrls is actually worthwhile. There's a bit of a disconnect with IvyArtifactRepository. MavenArtifactRepository has a base url, where we look for poms and artifacts, plus a set of artifactUrls, where we look for artifacts, if not found at the base url. IvyArtifactRepository effectively has a set of urls where we look for ivy descriptors and a separate set of urls where we look for artifacts. It also has some conveniences for adding the same url to both sets. So, perhaps we should change MavenArtifactRepository so that it has pomUrls and artifactUrls, and just have url as a convenience for adding a url to both sets. -- Adam Murdoch Gradle Co-founder http://www.gradle.org VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting http://www.gradleware.com
