I stumbled onto some known issues regarding file permissions in my current 
project, and decided to try to fix them. I've never worked with the Gradle 
source before, so I'm interested in some feedback before going any further with 
this.

I've committed a simple, first draft. No tests other than manual verification 
yet..
https://github.com/larshvile/gradle/commit/2025b546536177c6816bad633fa83ba36fb76a8a

Basically I've added FileTreeElement.getMode() and 
CopyProcessingSpec.setPreserveModes(). I'm assuming that backwards 
compatibility is important here (?). The current solution should hopefully 
behave 100% like the old one, unless the new 'preserveModes' option is used. 
However, preserving the original modes seems like a reasonable default to me..

Could someone please verify that this looks sane =) ? And if it is, what's the 
best practice for testing this kind of stuff? Creating integration tests within 
subprojects/integ-test?

-- 
Lars Hvile

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to