On 24 January 2012 13:09, Daz DeBoer <[email protected]> wrote:
> On 24 January 2012 02:16, Hans Dockter <[email protected]>wrote: > >> 1.) When we refresh the cache, do we plan also to consider the SHA1 >> values of the metadata files in the future? Right now we always download >> the metadata when we do a refresh. Not that I think this is a big issue. >> Just curious to understand the background and plans on this. >> > > We already do consider the SHA1 value of metadata files as well as > artifact files. But I think I found the bug that makes it look like it's > not working. > Our SHA1->String conversion is omitting any leading zero, so we are > truncating it to 39 characters in these cases. This means that in certain > cases our calculated SHA1 string does not match the published SHA1 string, > which has 40 characters. > I think this may have been the cause for MavenLocalCacheReuseIntegrationTest sporadically failing. If the maven publication was creating an SHA1 key with a leading zero, then we wouldn't have reused it. Thanks for pointing this out! cheers Daz
