On 25/06/13 12:00, Luke Daley wrote:
On 25/06/2013, at 9:09 AM, Marcin Erdmann <[email protected]> wrote:
Got super excited and wanted to try it out using a nightly build but got it to
throw an IndexOutOfBoundsException when:
- b depends on a
- a is finalized by c
- b is finalized by c
Just the regular start server -> run integration test -> shutdown server
scenario... This is really bad, wonder how I got such a common use case wrong, the
coverage seemed to be really good, yet it still happened. I will work on a pull
request for that tonight.
We are cutting RC-1 early next week. It would be good if we good at least get
some assessment of this done before then so we know the risks.
If you want some extra eyes on it let me know and I can help out.
This is fixed here: https://github.com/gradle/gradle/pull/169. Finaliser
tasks were scheduled too eagerly - now they are scheduled for inclusion
in execution plan after all of their dependencies that are currently
being processed for inclusion in execution plan.
I still believe that test coverage is pretty solid but it would be good
if you guys could come up with how this feature could be dogfooded. That
would probably exercise this code properly.
Marcin
P.s. I can see that Adam has already merged that PR. Thanks.
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
