Great, Luke. Thanks for the confirmation.
I'll tackle the PR comments soon.
Dan
On 2013-07-09 13:44, Luke Daley wrote:
Hi Dan,
I've added a few comments on the pull request.
The answer to your questions below are all yes.
I'll keep an eye on the pull request and reply to you there.
Thanks for contributing!
On 09/07/2013, at 2:44 AM, "Dan Stine" <s...@stinemail.com> wrote:
Hello,
I created a pull request [1] as a first attempt at addressing
GRADLE-2466 [2], and I have a few questions about the approach. In
particular, is it appropriate:
* for the new property to be typed as List<String>?
* for the new property to be named DefaultJvmOpts (instead of
GradleOpts, perhaps)
* to set DefaultJvmOpts on the script generator (instead of somehow
actually setting GRADLE_OPTS itself)
Other feedback also welcome, of course.
Thanks,
Dan
[1] https://github.com/gradle/gradle/pull/171
[2] http://issues.gradle.org/browse/GRADLE-2466
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
