jdaugherty opened a new pull request, #15055:
URL: https://github.com/apache/grails-core/pull/15055

   1. reproducibility issues
   @matrei noticed that he was having reproducibility issues for grails-redis 
when run under docker desktop.  These issues did not exist for me under 
orbstack or when running locally.
   
   Debugging this, the source jars were different because the file listings 
inside of the source jars were different.  Specifically, the listing across 
source sets - sometimes grails-app/init would be first and sometimes it would 
be later.  
   
   Digging into this, we do define the source / resource directories based on 
file system order instead of a deterministic order.  This PR sorts those to 
help these issues in the future (we may need to open an upstream gradle bug 
when using reproducibleFileOrder=true if this continues).  From what I can 
tell, the gradle source uses lists / linkedHashSets so as long as it's added in 
the same order, it's processed in the order.
   
   2. reproducible script issues 
   3. @matrei  noted the reproducible screw was failing because after a manual 
diff of all files, no differences were found.  The script did not exit properly 
or ensure a diff file existed.  @paulk-asert  has previously mentioned these 
issues in prior releases but I couldn't reproduce.  Going forward this should 
resolve this.
   
   3. KEYS file verification
   As part of 7.0.0-RC2 we started verifying both the grails github action 
files & the svn files to make sure they are identical.  We now will verify the 
KEYS files are identical so they're always kept in sync with grails-core.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to