Hi shilei,
your changes in sfx2/source/control/bindings.cxx
if( !pImpl || ((long)pImp)==0xfeeefeee)
Whatever you try to do with it, this is wrong. 0xfeeefeee is a value we
fill already freed memory in the
debug version only. I guess you have added this line because of a crash.
But this does not fix your
crash, you have to find the cause of the crash.
your changes in sd/source/ui/app/res_bmp.src
please put this floating window in its own .src file, best would be
sdsliderehearsalwin.src in the slideshow directory.
your changes in sd/source/ui/slideshow/slideshowimpl.cxx
Using a 1 second timer to implement a clock is not an option, you will
not get called every second. So please
rework your RehearsalWinSecondHdl that it gets the system time please
see osl/time.h.
Also the lines
Application::GetSolarMutex( ).acquire();
and
Application::GetSolarMutex().release();
are not exception save, please use a guard. A simple grep for
Application::GetSolarMutex() shows you
how to do it.
The next line, I do not understand what you try to do with them but
please remove them
mpShowWindow->GetParent()->SetBackground( aBlackWallpaper ); //set
background by using black
mpShowWindow->GetParent()->Invalidate( INVALIDATE_TRANSPARENT );
//update background
The following line should use a string from a resource with a
%PRODUCTNAME instead of OpenOffice.org
String aTit = String::CreateFromAscii("OpenOffice.org Impress");
For
aPageTimeVector.erase(aPageTimeVector.begin(), aPageTimeVector.end());
I think a aPageTimeVector.clear() should be enough
Please move implementation of SdSlideRehearsalWin to its own .cxx file
The new member mnFirstSlideNumber is not initialized in the constructor,
this may lead to problems.
You also misused mnLastSlideNumber. And the first non hidden slide is
not always the number
of the last slide. Did you understand that the highest slide number can
be the first visible slide by
using a custom show?
I do not understand why you changed SlideshowImpl::getFirstSlideNumber()
and SlideShowImpl::getLastSlideNumber(),
but you killed the custom slide show mode with that.
I have not looked more into details but the above notes are thinks that
definitely must be changed.
Regards,
Christian
shilei wrote:
> Hi,Christian and list members.
> I have created a cws about my new feature for thr OOo.Please give me
> your suggestion ahout the code .The name of cws is
> DEV300/rehearsetiming080318
> <cws.EditCWS?Id=6616&ERV_NextPage=cws.ShowCWS%3FId%3D6616%26logon%3Dtrue>,and
> the code is based on DEV300 m2 .I think the code need more modification
> to make the code better.Thanks !
>
> shilei
> Best wishes!
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Sun Microsystems GmbH
Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Gescha"ftsführer: Thomas Schro"der, Wolfgang Engels, Dr. Roland Bo"mer
Vorsitzender des Aufsichtsrates: Martin Ha"ring
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
