Hi,

Christian Lippka - Sun Microsystems Gmbh - Hamburg wrote:
Am 24.02.2010 09:02, schrieb Tobias Koenig:
On Tue, Feb 23, 2010 at 06:03:39PM +0100, Christian Lippka - Sun Microsystems Gmbh - Hamburg wrote:
Hi Tobias,
Hej Christian,

thank you very much for the elaborate answer, I have created a patch
now that sets the default style on the object in the ImplSdPPTImport::ProcessObj
method and now the export finds the style as expected.
Cool, I bet sj loves to review this patch.
For sure I love it.
Be carefull not to set the styles for shapes created with the
CreatePresObj method as they need and
automatically get presentation styles.
How can I find out whether an object has been created by CreatePresObj
or not? Do these SdrObjects belong to a special category or do they
have some flag set?
These are the title, subtitle, outline, graphic or ole shapes that are part of the presentation layout. Therefore they have on of the presentation styles set not the graphic styles. One can check them out by calling IsPresObj on the slide they are inserted into. But that should not be needed if the ppt import does not call ProcessObj for such shapes. Maybe sven can tell us a bit more
about this I put him on cc.
ProcessObj is called from SvxMSDffManager::ImportShape for each shape once. In SvxMSDffManager::ImportShape a shape is created which is passed to ProcessObj for further object modification. In ProcessObj you are having access to the corresponding application (Impress/Calc/Writer), so application dependent properties / features can be applied. Not calling ProcessObj for presentation objects is no option, because then
we cannot apply animations and similar.

At the moment, styles are set at ApplyTextObj, which is called for each shape that is containing text, this is good for shapes with text, but we are missing shapes
without text, so this seems to be the problem here.

I think each application is having its own style handling for objects, so the right place to set the style would be at the end of each ProcessObj method, as the shape that is returned from the method will be inserted into the page, there I would set the
default style if no one is applied.

Best regards,
Sven


Regards,
Christian


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to