Hi Mingyuan, I think the design doc looks generally OK, but still lacks some details, for example,
1. The type mapping relation between Gravitino and OB, does OB have some particular types that Gravitino cannot support, and how to handle it? 2. The partition strategy of OB and how to map to Gravitino, other about distributions, sort orders, indexing. 3. Does OB have some special metadata that cannot be supported by Gravitino, and how to do it? I think these things should be sorted out, so that we can have a good support for OB. BTW, I will ask Minghuang in the CC list to shepherd you to fulfill all the work about adding a new catalog. Best, Jerry 赵明远(远疏) <zhaomingyuan....@digital-engine.com> 于2024年9月1日周日 18:47写道： > Hi Saisai, > > Thanks for your reminder, I have updated the permissions. > > Best, > yuan > > ------------------------------------------------------------------ > 发件人：Saisai Shao<sai.sai.s...@gmail.com> > 日 期：2024年09月02日 01:31:40 > 收件人：<dev@gravitino.apache.org> > 抄 送：赵明远(远疏)<zhaomingyuan....@digital-engine.com> > 主 题：Re: [DISCUSS] Adding OceanBase JDBC Catalog Support in Gravitino > > Hi Mingyuan, > > Thanks a lot for your proposal, can you please open the "commenter" > permissions of the design doc, so that we can put the comment on the doc. > > Best, > Jerry > > 俊平堵 <junping...@apache.org> 于2024年8月27日周二 21:10写道： > >> Thanks Mingyuan for your contribution! >> +1 on adding more open source DB support, such as OB, etc. >> >> Thanks, >> >> JP >> >> roryqi <ror...@apache.org> 于2024年8月27日周二 21:06写道： >> >> > Appreciate for your work. I will read the document later. >> > >> > Best >> > Rory >> > >> > >> > >> > >> > >> > 赵明远(远疏) <zhaomingyuan....@digital-engine.com.invalid> 于2024年8月28日周三 >> > 11:11写道： >> > >> > > Hi all, >> > > Gravitino currently supports the MySQL catalog[1], PostgreSQL >> catalog[2] >> > > and Apache Doris catalog[3] for metadata management but does not >> support >> > > OceanBase[4] yet. I'd like to start a discussion about adding >> OceanBase >> > > JDBC catalog support to Gravitino. >> > > This integration could potentially expand Gravitino's capabilities in >> > > managing relational database metadata. >> > > I've opened a Github issue to discuss this proposal: >> > > https://github.com/apache/gravitino/issues/4353 < >> > > https://github.com/apache/gravitino/issues/4353 > >> > > And I have completed the main code and submitted a PR: >> > > https://github.com/apache/gravitino/pull/4626 < >> > > https://github.com/apache/gravitino/pull/4626 > >> > > A draft design document is available here: >> > > >> > >> https://docs.google.com/document/d/19IQNeh-tXmgOIbDuy8yMSoqDpl-jp26HjvlR5ByeQLY/edit?usp=sharing >> > > < >> > > >> > >> https://docs.google.com/document/d/19IQNeh-tXmgOIbDuy8yMSoqDpl-jp26HjvlR5ByeQLY/edit?usp=sharing >> > > > >> > > I'd appreciate the community's thoughts on: >> > > >> > > * >> > > Is this feature aligned with Gravitino's goals? >> > > >> > > * >> > > Are there any concerns or potential issues we should address? >> > > >> > > * >> > > Any suggestions for improving the design or implementation approach? >> > > If there's interest in pursuing this, I'm willing to continue to >> improve >> > > the above PR. However, I'm open to any feedback or alternative >> approaches >> > > the community might suggest. >> > > Thanks for your time and input. >> > > Best, >> > > yuanoOo >> > > [1] >> > > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-mysql-catalog.md >> > < >> > > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-mysql-catalog.md >> > > >> > > [2] >> > > >> > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-postgresql-catalog.md >> > > < >> > > >> > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-postgresql-catalog.md >> > > > >> > > [3] >> > > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-doris-catalog.md >> > < >> > > >> https://github.com/apache/gravitino/blob/main/docs/jdbc-doris-catalog.md >> > > >> > > [4] https://www.oceanbase.com/ <https://www.oceanbase.com/ > >> > > >> > >> > >
