+1 I have checked the following: 1. The package was signed by minghuang. 2. The src can be successfully built and then run with JDK8 on MacOS (13.3 (22E252)). 3. The documents page is satisfactory.
ShaoFeng Shi <shaofeng...@apache.org> 于2024年10月14日周一 11:36写道： > +1 (binding) shaofengshi (PPMC/IPMC) > > I checked: > - the signatures are made by comitter minghuang > - the hashes are good > - LICENSE and NOTICE are included > - compile success on my Mac with Java 1.8 > > > Best regards, > > Shaofeng Shi 史少锋 > Apache Kylin PMC member, > Apache Incubator PMC member, > Email: shaofeng...@apache.org > > > > > > > Minghuang Li <mcha...@apache.org> 于2024年10月14日周一 10:26写道： > > > Hi Justin, > > > > Thank you for your vote and pointing out the license issue. > > > > I noticed the tpcds data files you mentioned, which are located in the > > test module and explicitly excluded from the RAT check task. I am not > sure > > if this will affect the 0.6.1-incubating release or if the incubator will > > allow us to fix them in the 0.7.0-incubating release? > > > > Best > > Minghuang Li > > > > On 2024/10/12 19:16:37 Justin Mclean wrote: > > > Hi, > > > > > > +1 (binding) jmclean (PPMC/IPMC) > > > > > > For the releases, I checked: > > > - incubating in name > > > - signatures and hashes are fine > > > - LICENSE and NOTICE still need work in source and binary artefacts > > > - DISCLAIMER (WIP) exists > > > - all ASF files have correct headers > > > - no unexpected binary files > > > - can compile from source > > > > > > More work is needed on the LICENSE and NOTICE files, as some of their > > contents are incorrect or missing; for example, how is the tpcds data > > licensed? > > > > > > Kind Regards, > > > Justin > > > > > >
