Justin, thanks for pointing out the issue, I create corresponding issues on GitHub to track them: 1. https://github.com/apache/gravitino/issues/6331 2. https://github.com/apache/gravitino/issues/6330 3. https://github.com/apache/gravitino/issues/6329
Best Xiaojing On Mon, Jan 20, 2025 at 9:10 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) from me > > I checked: > - signatures and hashes are fine > - LICENSE and NOICE are good > - DISCLAIMER exists > - no unexpected binary files > - most files have ASF headers (see below) > - can compile from source, but one test fails > > One very minor issue, I did notice we’re using the OceanBase logo. I > couldn’t find any conditions on how to use their trademark on their > website, so it would be best to ask for permission to use it. > > There are a couple of files that possibly should have ASF headers > [1][2][3], assuming they are our files and not copied from somewhere? If > they were copied then they need to be listed in LICENSE. Perhaps these > files come from Hadoop like hadoop-env.sh and yarn-env.sh??? > > I also run into a test failure: > TestChainedAuthorizationIT > initializationError FAILED > java.lang.RuntimeException: Failed to initialize ContainerSuite > at > org.apache.gravitino.integration.test.container.ContainerSuite.initIfNecessary(ContainerSuite.java:103) > at > org.apache.gravitino.integration.test.container.ContainerSuite.startRangerContainer(ContainerSuite.java:519) > at > org.apache.gravitino.authorization.ranger.integration.test.RangerITEnv.init(RangerITEnv.java:94) > at > org.apache.gravitino.authorization.chain.integration.test.TestChainedAuthorizationIT.startIntegrationTest(TestChainedAuthorizationIT.java:85) > > Caused by: > java.lang.IllegalStateException: Could not find a valid Docker > environment. Please see logs and check configuration > at > org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$7(DockerClientProviderStrategy.java:277) > at java.util.Optional.orElseThrow(Optional.java:290) > at > org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:268) > at > org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:152) > at > org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:193) > at > org.apache.gravitino.integration.test.container.ContainerSuite.initIfNecessary(ContainerSuite.java:94) > ... 3 more > > Shouldn't people be able to compile without docker running? > > Kind Regards, > Justin > > 1. ./dev/docker/kerberos-hive/kadm5.acl > 2. ./dev/docker/kerberos-hive/kdc.conf > 3. ./dev/docker/kerberos-hive/krb5.conf
