Hi Justin,

For the source package, I checked:
- incubating in artifacts names
- signatures and hashes are good
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files in the source release
- source files have ASF headers
- maven staging artifacts provided
- rc4 tag created in the github repo

While, I noticed the source package seems not be created from the tag and
commit id you provided (949237c), here are two differences:

1. in the "clients/filesystem-fuse/Cargo.toml", it is:
version = "0.8.0-incubating-SNAPSHOT"

while in the rc4 tag it is (
https://github.com/apache/gravitino/blob/v0.8.1-incubating-rc4/clients/filesystem-fuse/Cargo.toml
):
version = "0.8.1-incubating"

2. in the "docs/index.md" it is:

Java SDK definition in [Gravitino Java
doc](pathname:///docs/0.9.0-incubating-SNAPSHOT/api/java/index.html)

while in the rc4 tag, it is:

Java SDK definition in [Gravitino Java
doc](pathname:///docs/0.8.1-incubating/api/java/index.html),

Obviously, the source package has mistakes. So, could you please double
check that, the release source package was created from the tag/commit you
provided?

Best regards,

Shaofeng Shi 史少锋
Apache Incubator PMC member,
Email: shaofeng...@apache.org






Justin Mclean <jus...@classsoftware.com> 于2025年4月17日周四 10:17写道:

> Hi,
>
> +1 (binding)
>
> I downloaded the artifacts on a separate machine from which I made the
> release and checked the following:
> - incubating in artifacts names
> - signatures and hashes are good
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files in the source release
> - source files have ASF headers
> - Can compile from source
>
> I could also start a Gravatino web server and the web UI.
>
> Kind Regards,
> Justin

Reply via email to