Github user bhlx3lyx7 commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/463#discussion_r238088257
--- Diff:
measure/src/test/scala/org/apache/griffin/measure/utils/HttpUtilTest.scala ---
@@ -0,0 +1,63 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package org.apache.griffin.measure.utils
+
+import org.scalatest.{FlatSpec, Matchers}
+
+class HttpUtilTest extends FlatSpec with Matchers {
+ val url = "http://10.148.181.248:39200/griffin/accuracy";
--- End diff --
Seems like this ip address is a specific one, which will not work for other
environments.
Actually, all the test cases throw the "connect timed out" exception in my
IDE.
You need to mock the http request actions for this UT.
---
