Github user ahutsunshine commented on a diff in the pull request:

    https://github.com/apache/griffin/pull/468#discussion_r239800609
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java ---
    @@ -98,7 +100,12 @@ public void execute(JobExecutionContext context) {
                     updateJobInstanceState(context);
                     return;
                 }
    -            saveJobInstance(jd);
    +            if(livyTaskSubmitHelper.isNeedLivyQueue()){
    +                //livy batch limit
    +                livyTaskSubmitHelper.addTaskToWaitingQueue(livyConfMap);
    +            }else{
    +                saveJobInstance(jd);
    +            }
    --- End diff --
    
    As you modify the job execution process, you need to update relevant tests 
in SparkSubmitJobTest class to make travis build pass.


---

Reply via email to