[
https://issues.apache.org/jira/browse/GRIFFIN-232?focusedWorklogId=210622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210622
]
ASF GitHub Bot logged work on GRIFFIN-232:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/19 03:37
Start Date: 10/Mar/19 03:37
Worklog Time Spent: 10m
Work Description: chemikadze commented on pull request #484: GRIFFIN-232
- add support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#discussion_r264022312
##########
File path: service/pom.xml
##########
@@ -291,7 +292,7 @@ under the License.
</execution>
</executions>
<configuration>
- <classifier>exec</classifier>
+
<classifier>${spring-boot-maven-plugin.classifier}</classifier>
Review comment:
Let implement it in a way, that library jar is built on every build with its
own classifier ("lib"?), without need to specify classifier explicitly, and
keep exec semantics of default jar. Otherwise we'll have semantics of artifacts
changing within same classifier depending on build settings, which is very
error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 210622)
Time Spent: 1h 20m (was: 1h 10m)
> Implement pluggable Predicators in PredicatorFactory
> ----------------------------------------------------
>
> Key: GRIFFIN-232
> URL: https://issues.apache.org/jira/browse/GRIFFIN-232
> Project: Griffin (Incubating)
> Issue Type: Improvement
> Reporter: Aleksandr Borgatin
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I propose add second type of predicate after "file.exist" - "custom". JSON
> example for creation "custom" predicate
> {code:java}
> {
> "type": "custom",
> "config": {
> "class":
> "org.apache.griffin.core.job.FileExistPredicator",
> "root.path": "/path/to/",
> "path": "file.ext,file2.txt"
> }
> }
> {code}
> Proposed contract for implementations is based on FileExistPredicator:
> * class must implement interface *org.apache.griffin.core.job.Predicator*
> * class must have constructor with argument of type
> *org.apache.griffin.core.job.entity.SegmentPredicate*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
