[jira] [Work logged] (GRIFFIN-240) [Service] Return JobInstance in response to a call Trigger job by id

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=215417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215417
 ]

ASF GitHub Bot logged work on GRIFFIN-240:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/19 12:36
            Start Date: 19/Mar/19 12:36
    Worklog Time Spent: 10m 
      Work Description: aborgatin commented on pull request #489: GRIFFIN-240 
Return JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266864068
 
 

 ##########
 File path: 
service/src/main/java/org/apache/griffin/core/job/entity/JobInstanceBean.java
 ##########
 @@ -85,6 +85,8 @@ Licensed to the Apache Software Foundation (ASF) under one
     @JsonIgnore
     private AbstractJob job;
 
+    private String triggerName;
 
 Review comment:
   This is schema change will be applied automatically
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 215417)
    Time Spent: 2h  (was: 1h 50m)

> [Service] Return JobInstance in response to a call Trigger job by id 
> ---------------------------------------------------------------------
>
>                 Key: GRIFFIN-240
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-240
>             Project: Griffin (Incubating)
>          Issue Type: Improvement
>            Reporter: Aleksandr Borgatin
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to 
> return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws 
> SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
>     @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
>     @ResponseStatus(HttpStatus.NO_CONTENT)
>     public void triggerJob(@PathVariable("id") Long id) throws 
> SchedulerException {
>         jobService.triggerJobById(id);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)