[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222122
]
ASF GitHub Bot logged work on GRIFFIN-244:
------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/19 02:11
Start Date: 03/Apr/19 02:11
Worklog Time Spent: 10m
Work Description: chemikadze commented on pull request #492: GRIFFIN-244
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271557391
##########
File path:
service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java
##########
@@ -61,4 +72,38 @@ public void setTmst(Long tmst) {
public void setValue(Map<String, Object> value) {
this.value = value;
}
+
+ public String getApplicationId() {
Review comment:
Suddenly I've realized that probably more extensible way would be to have
"metadata" map on metric, instead of fixed "applicationId" value. Who knows
what can be useful later.
I know that applicationId is already part of the code base, but as it's not
read from anywhere and we did not release that code, it can be right moment to
change it. But later we'll be at point of no return.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222122)
Time Spent: 2h (was: 1h 50m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> ---------------------------------------------------------------------------------
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
> Reporter: Dmitry Ershov
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
