dershovGD commented on a change in pull request #492: GRIFFIN-244 get metrics
by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271835189
##########
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##########
@@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user,
String password) {
@Override
public MetricValue getMetric(String applicationId) throws IOException {
- Map<String, String> map = new HashMap<>();
- map.put("q", "applicationId:" + applicationId);
- Response response = client.performRequest("GET", urlGet, map);
+ Response response0 = client.performRequest(
Review comment:
Looks like this value never used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services